From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B1A60941F9 for ; Thu, 23 Feb 2023 10:49:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9417A22E1C for ; Thu, 23 Feb 2023 10:49:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 23 Feb 2023 10:49:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4EA75482DB for ; Thu, 23 Feb 2023 10:49:06 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Thu, 23 Feb 2023 10:49:03 +0100 Message-Id: <20230223094903.29376-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, proxmox.com] Subject: [pve-devel] [PATCH qemu-server] start: make not being able to set polling interval for ballooning non-critical X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2023 09:49:37 -0000 The guest will be running, so it's misleading to fail the start task here. Also ensures that we clean up the hibernation state upon resume even if there is an error here, which did not happen previously[0]. [0]: https://forum.proxmox.com/threads/123159/ Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index a1a8b937..ff1e3c72 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -6053,13 +6053,16 @@ sub vm_start_nolock { } if (!defined($conf->{balloon}) || $conf->{balloon}) { - mon_cmd( - $vmid, - 'qom-set', - path => "machine/peripheral/balloon0", - property => "guest-stats-polling-interval", - value => 2 - ); + eval { + mon_cmd( + $vmid, + 'qom-set', + path => "machine/peripheral/balloon0", + property => "guest-stats-polling-interval", + value => 2 + ); + }; + log_warn("could not set polling interval for ballooning - $@") if $@; } if ($resume) { -- 2.30.2