From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6F6D093BD7 for ; Wed, 22 Feb 2023 10:39:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 51D46D154 for ; Wed, 22 Feb 2023 10:39:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 22 Feb 2023 10:39:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5CE4A457B4 for ; Wed, 22 Feb 2023 10:39:31 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Wed, 22 Feb 2023 10:39:30 +0100 Message-Id: <20230222093930.2659526-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230222093655.2645787-3-a.lauterer@proxmox.com> References: <20230222093655.2645787-3-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager follow-up 2/2] ui: ceph status: add tooltip with details to warnings X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2023 09:39:32 -0000 This is another step to make it easier for admins to discover more information for a warning or problem that is shown in the Ceph health panel. The length is limited to give a first glimpse. For the full details one can click on the info/detail button. Signed-off-by: Aaron Lauterer --- Please use this follow up! I found a small bug just after sending it regarding the max length. The length check and substring did have different values. www/manager6/ceph/Status.js | 41 +++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js index 45583f51..19a1243a 100644 --- a/www/manager6/ceph/Status.js +++ b/www/manager6/ceph/Status.js @@ -76,6 +76,47 @@ Ext.define('PVE.node.CephStatus', { trackRemoved: false, data: [], }, + + listeners: { + destroy: function() { + let view = this.getView(); + if (view.tooltip) { + view.tooltip.destroy(); + delete view.tooltip; + } + }, + itemmouseenter: function(record, item) { + let view = this.getView(); + if (!view) { + return; + } + if (!item.data.detail) { + return; + } + let text = item.data.detail.trimStart().replaceAll('\n', '
'); + if (text.length > 500) { + text = `${text.substring(0, 500)}…`; + } + if (!view.tooltip) { + view.tooltip = Ext.create('Ext.tip.ToolTip', { + target: view, + trackMouse: true, + dismissDelay: 0, + tpl: '{text}', + renderTo: Ext.getBody(), + }); + } + view.tooltip.setData({ text }); + view.tooltip.show(); + }, + itemmouseleave: function(record, item) { + let view = this.getView(); + if (view.tooltip) { + view.tooltip.destroy(); + delete view.tooltip; + } + }, + }, emptyText: gettext('No Warnings/Errors'), columns: [ { -- 2.30.2