From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6E0BC93994 for ; Tue, 21 Feb 2023 14:14:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 49CB32E52 for ; Tue, 21 Feb 2023 14:13:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 21 Feb 2023 14:13:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1245E47F41 for ; Tue, 21 Feb 2023 14:13:31 +0100 (CET) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Tue, 21 Feb 2023 14:13:16 +0100 Message-Id: <20230221131318.4043599-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.145 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] [PATCH proxmox-acme 0/2] add missing _clearaccountconf_mutable and improve check-missing script X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2023 13:14:02 -0000 I think I've seen similar reports a few times in our community-forum, but never followed through - or thought it was fixed by some other issue: https://forum.proxmox.com/threads/.122961/ While fixing the concrete issue for dns_cf.sh I tried to enhance our check-missing-function helper to catch such issues (now it caught the missing _clearaccountconf_mutable). Patches are ordered inversely to their implementation, so that `make deb` does not fail on the first commit. Stoiko Ivanov (2): proxmox-acme: add empty _clearaccountconf_mutable helper tests: add non-word boundary to present functions src/proxmox-acme | 4 ++++ src/test/check-missing-functions | 4 ++-- src/test/missing-functions.expected | 1 + 3 files changed, 7 insertions(+), 2 deletions(-) -- 2.30.2