From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D7CBB9357D for ; Mon, 20 Feb 2023 11:05:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B23A224FE7 for ; Mon, 20 Feb 2023 11:05:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 20 Feb 2023 11:05:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F214747BE8 for ; Mon, 20 Feb 2023 11:05:14 +0100 (CET) From: Friedrich Weber To: pve-devel@lists.proxmox.com Date: Mon, 20 Feb 2023 11:04:45 +0100 Message-Id: <20230220100445.1912573-1-f.weber@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.655 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH container] fix #4470: pct fstrim: ignore bind or read-only mountpoints X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Feb 2023 10:05:46 -0000 Currently, `pct fstrim` will run `fstrim` on all mountpoints of the container, including bind and read-only mountpoints. However, trimming a bind mountpoint might trim a host filesystem, which users may not expect. Also, trimming can be considered a write operation, which users may not expect to be carried out on a read-only mountpoint. Hence, exclude bind mointpoints and read-only mountpoints from trimming. Signed-off-by: Friedrich Weber --- src/PVE/CLI/pct.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 3ade2ba..d559d00 100755 --- a/src/PVE/CLI/pct.pm +++ b/src/PVE/CLI/pct.pm @@ -763,7 +763,7 @@ __PACKAGE__->register_method ({ name => 'fstrim', path => 'fstrim', method => 'POST', - description => "Run fstrim on a chosen CT and its mountpoints.", + description => "Run fstrim on a chosen CT and its mountpoints, except bind or read-only mountpoints.", parameters => { additionalProperties => 0, properties => { @@ -791,6 +791,7 @@ __PACKAGE__->register_method ({ PVE::LXC::Config->foreach_volume($conf, sub { my ($name, $mp) = @_; $path = $mp->{mp}; + return if $mp->{type} eq 'bind' || $mp->{ro}; return if $param->{'ignore-mountpoints'} && $name =~ /^mp\d+/; my $cmd = ["fstrim", "-v", "$rootdir$path"]; PVE::Tools::run_command($cmd, noerr => 1); -- 2.30.2