From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DE4AA92DF9 for ; Wed, 15 Feb 2023 15:03:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3DCF31E34D for ; Wed, 15 Feb 2023 15:03:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 15 Feb 2023 15:03:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 27AFD4736A for ; Wed, 15 Feb 2023 15:03:02 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Wed, 15 Feb 2023 15:02:41 +0100 Message-Id: <20230215140245.496507-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.119 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 container/manager 0/4] fix #3413: Add `Disconnect` option for LXC networks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2023 14:03:36 -0000 Add a `Disconnect` option for network interfaces on LXC containers, much like it already exists for VMs. This has been requested in #3413 [0] and seems useful, especially considering we already support the same thing for VMs. One thing to note is that LXC does not seem to support the notion of setting an interface down. The `flags` property would suggest that this possible [1], but AFAICS it does not work. I tried setting the value as empty and to something else than "up" (since that is really the only supported option [2][3]), which both had absolutely no effect. Thus force the host-side link of the container network down and avoid adding it to the designated bridge if the new option is set, effectively disconnecting the container network. The first two patches are cleanup-patches only and do not change anything regarding functionality. Testing ------- Testing was done by starting a LXC container (w/ and w/o `link-down` set), checking if the interface has (or not) LOWERLAYERDOWN set inside the container (`ip address eth0`) and if packet transit works (or not) using a simple `ping`. Same thing after toggeling the option on the interface. Further, the interface(s) should (or should not) be listed in `brctl show`. Same thing was done for hotplugged interfaces to a running container. Also tested with `ifreload -a` (thanks Wolfgang!) thrown in, which did nothing unexpected: If `link-down` was set, interfaces stayed in LOWERLAYERDOWN and unplugged from the bridge, and stayed UP and plugged into the bridge when `link-down` was unset. [0] https://bugzilla.proxmox.com/show_bug.cgi?id=3413 [1] https://linuxcontainers.org/lxc/manpages/man5/lxc.container.conf.5.html#lbAO [2] https://github.com/lxc/lxc/blob/08f0e769/src/lxc/confile.c#L453-L467 [3] https://github.com/lxc/lxc/blob/08f0e769/src/lxc/confile.c#L5933-L5952 v1: https://lists.proxmox.com/pipermail/pve-devel/2023-February/055762.html pve-container: Christoph Heiss (3): lxc: Fix some trailing whitespace net: Avoid open-coding normal vs SDN-specific tap_plug() net: Add `link-down` config to allow setting interfaces as disconnected src/PVE/LXC.pm | 41 ++++++++++++++++++++++++++++++++++------- src/PVE/LXC/Config.pm | 5 +++++ src/lxcnetaddbr | 7 +++++-- 3 files changed, 44 insertions(+), 9 deletions(-) pve-manager: Christoph Heiss (1): lxc: Add `Disconnect` option for network interfaces www/manager6/Parser.js | 3 +++ www/manager6/lxc/Network.js | 13 +++++++++++++ 2 files changed, 16 insertions(+) -- 2.39.1