From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3680892B2B for ; Tue, 14 Feb 2023 14:35:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 181D58736 for ; Tue, 14 Feb 2023 14:35:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 14 Feb 2023 14:35:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 09E2946FED for ; Tue, 14 Feb 2023 14:35:11 +0100 (CET) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Tue, 14 Feb 2023 14:35:08 +0100 Message-Id: <20230214133508.760282-1-l.wagner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.165 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] [PATCH manager] ui: ldap: fix `Parameter verification error` X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2023 13:35:12 -0000 ...when editing LDAP realm sync settings and only a single property is empty and thus to be deleted (e.g. values.delete = "filter"). If `delete` is a simple string and not an array, `PVE.Utils.delete_if_default` simply creates a comma-separated list, (e.g. value.delete = "filter,sync-attributes"). When the properties from the other panel are evaluated and added to the the `delete` property, comma-separated list format is not considered, leading to a final value for `delete` that could look like this: value.delete = { "server2", "comment", "filter,sync-attributes" } This commit fixes this by splitting `delete` in case it is a string. Reported-by: Friedrich Weber Signed-off-by: Lukas Wagner --- Same fix as in my LDAP widget-toolkit patch series: https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005952.html www/manager6/dc/AuthEditLDAP.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/www/manager6/dc/AuthEditLDAP.js b/www/manager6/dc/AuthEditLDAP.js index 96ef77b9..2ce16e58 100644 --- a/www/manager6/dc/AuthEditLDAP.js +++ b/www/manager6/dc/AuthEditLDAP.js @@ -139,6 +139,11 @@ Ext.define('PVE.panel.LDAPSyncInputPanel', { PVE.Utils.delete_if_default(values, 'sync-defaults-options'); PVE.Utils.delete_if_default(values, 'sync_attributes'); + // Force values.delete to be an array + if (typeof values.delete === 'string') { + values.delete = values.delete.split(','); + } + if (me.isCreate) { delete values.delete; // on create we cannot delete values } -- 2.30.2