From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <c.heiss@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 3753192A89
 for <pve-devel@lists.proxmox.com>; Tue, 14 Feb 2023 11:11:01 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 204C65F39
 for <pve-devel@lists.proxmox.com>; Tue, 14 Feb 2023 11:11:01 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Tue, 14 Feb 2023 11:10:56 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 76CDC4713E
 for <pve-devel@lists.proxmox.com>; Tue, 14 Feb 2023 11:10:56 +0100 (CET)
Date: Tue, 14 Feb 2023 11:10:54 +0100
From: Christoph Heiss <c.heiss@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Message-ID: <20230214101054.22s7psxojrxmoena@maui.proxmox.com>
References: <20230213135700.502195-1-c.heiss@proxmox.com>
 <20230213135700.502195-2-c.heiss@proxmox.com>
 <3aac0a5d-ce0b-747e-1b16-ed3e70489edb@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3aac0a5d-ce0b-747e-1b16-ed3e70489edb@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.130 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH container 1/2] net: Add `link_down` config
 to allow setting interfaces as disconnected
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 14 Feb 2023 10:11:01 -0000

On Tue, Feb 14, 2023 at 10:52:15AM +0100, Thomas Lamprecht wrote:
> On 13/02/2023 14:56, Christoph Heiss wrote:
> > +    link_down => {
> > +	type => 'boolean',
> > +	description => 'Whether this interface should be disconnected (like pulling the plug).',
> > +	optional => 1,
> > +    },
>
> I'd prefer using kebab-case over snake_case for new properties, or do
> we really gain anything here (e.g., qemu-server related infra reuse?)
Not that I would see. This was very much inspired by the qemu-server API
and would provide some form of "uniformity" between those two, but I
will change that for v2. kebap-case is nicer anyway.

>
> besides from that, the patch here contains quite some unrelated whitespace
> changes, please avoid that.
That was intentional (as noted), since there are trailing whitespaces
all over the file, which can be somewhat annoying if one's editor
automatically trims trailing whitespaces on save purposefully.
But I will omit that from the next revision, fine by me.