From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F1EC9929A6 for ; Tue, 14 Feb 2023 09:14:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CCDCD4912 for ; Tue, 14 Feb 2023 09:13:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 14 Feb 2023 09:13:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 63961470F9 for ; Tue, 14 Feb 2023 09:13:48 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Tue, 14 Feb 2023 09:13:47 +0100 Message-Id: <20230214081347.4012305-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [osd.pm] Subject: [pve-devel] [PATCH manager] ceph osd: ui: show PGs per OSD X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2023 08:14:20 -0000 By switching from 'ceph osd tree' to the 'ceph osd df tree' mon API equivalent , we get the same data structure with more information per OSD. One of them is the number of PGs stored on that OSD. The number of PGs per OSD is an important number, for example when trying to figure out why the performance is not as good as expected. Therefore, adding it to the OSD overview visible by default should reduce the number of times, one needs to access the CLI. Signed-off-by: Aaron Lauterer --- PVE/API2/Ceph/OSD.pm | 4 ++-- www/manager6/ceph/OSD.js | 7 +++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm index 18195743..09fb3bba 100644 --- a/PVE/API2/Ceph/OSD.pm +++ b/PVE/API2/Ceph/OSD.pm @@ -105,7 +105,7 @@ __PACKAGE__->register_method ({ PVE::Ceph::Tools::check_ceph_inited(); my $rados = PVE::RADOS->new(); - my $res = $rados->mon_command({ prefix => 'osd tree' }); + my $res = $rados->mon_command({ prefix => 'osd df', output_method => 'tree', }); die "no tree nodes found\n" if !($res && $res->{nodes}); @@ -131,7 +131,7 @@ __PACKAGE__->register_method ({ type => $e->{type} }; - foreach my $opt (qw(status crush_weight reweight device_class)) { + foreach my $opt (qw(status crush_weight reweight device_class pgs)) { $new->{$opt} = $e->{$opt} if defined($e->{$opt}); } diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index 6f7e2159..ef193a0a 100644 --- a/www/manager6/ceph/OSD.js +++ b/www/manager6/ceph/OSD.js @@ -797,6 +797,13 @@ Ext.define('PVE.node.CephOsdTree', { renderer: 'render_osd_latency', width: 120, }, + { + text: 'PGs', + dataIndex: 'pgs', + align: 'right', + renderer: 'render_osd_val', + width: 90, + }, ], -- 2.30.2