From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4CC2E919E6 for ; Thu, 2 Feb 2023 15:42:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2E748E09D for ; Thu, 2 Feb 2023 15:41:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 2 Feb 2023 15:41:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AD9EF43792 for ; Thu, 2 Feb 2023 15:41:36 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 2 Feb 2023 15:41:33 +0100 Message-Id: <20230202144135.3892582-5-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230202144135.3892582-1-d.csapak@proxmox.com> References: <20230202144135.3892582-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v2 4/6] ui: refactor refreshing the the resource store/tree X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Feb 2023 14:42:08 -0000 we'll need it elsewhere too, and it was rather hidden in the updateTagSettings call. Signed-off-by: Dominik Csapak --- www/manager6/UIOptions.js | 13 ++++++++----- www/manager6/dc/OptionView.js | 1 + 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/www/manager6/UIOptions.js b/www/manager6/UIOptions.js index c80a7c859..dcdf01ee1 100644 --- a/www/manager6/UIOptions.js +++ b/www/manager6/UIOptions.js @@ -16,6 +16,7 @@ Ext.define('PVE.UIOptions', { PVE.UIOptions.updateTagList(PVE.UIOptions.options['allowed-tags']); PVE.UIOptions.updateTagSettings(PVE.UIOptions.options['tag-style']); + PVE.UIOptions.fireUIConfigChanged(); }, }); }, @@ -65,11 +66,6 @@ Ext.define('PVE.UIOptions', { } Ext.ComponentQuery.query('pveResourceTree')[0].setUserCls(`proxmox-tags-${shape}`); - - if (!PVE.data.ResourceStore.isLoading() && PVE.data.ResourceStore.isLoaded()) { - PVE.data.ResourceStore.fireEvent('load'); - } - Ext.GlobalEvents.fireEvent('loadedUiOptions'); }, tagTreeStyles: { @@ -89,4 +85,11 @@ Ext.define('PVE.UIOptions', { shouldSortTags: function() { return !(PVE.UIOptions.options['tag-style']?.ordering === 'config'); }, + + fireUIConfigChanged: function() { + if (!PVE.data.ResourceStore.isLoading() && PVE.data.ResourceStore.isLoaded()) { + PVE.data.ResourceStore.fireEvent('load'); + } + Ext.GlobalEvents.fireEvent('loadedUiOptions'); + }, }); diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js index 4435876dd..f36a68560 100644 --- a/www/manager6/dc/OptionView.js +++ b/www/manager6/dc/OptionView.js @@ -566,6 +566,7 @@ Ext.define('PVE.dc.OptionView', { PVE.UIOptions.options['tag-style'] = store.getById('tag-style')?.data?.value; PVE.UIOptions.updateTagSettings(PVE.UIOptions.options['tag-style']); + PVE.UIOptions.fireUIConfigChanged(); }); me.on('activate', me.rstore.startUpdate); -- 2.30.2