From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 34AD596F46 for ; Fri, 27 Jan 2023 11:14:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 13FE86C5A for ; Fri, 27 Jan 2023 11:14:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 27 Jan 2023 11:14:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 48D81443BC for ; Fri, 27 Jan 2023 11:14:37 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 27 Jan 2023 11:14:35 +0100 Message-Id: <20230127101436.2200018-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230127101436.2200018-1-d.csapak@proxmox.com> References: <20230127101436.2200018-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.063 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit 1/1] ComboGrid: avoid needing two clicks after reselecting an item X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2023 10:14:38 -0000 'picker.hide()' hides the picker, but does not do everything to properly keep track of the picker state in the combobox class. This lead to a bug when we reselected an entry, we had to click the picker again twice to open it again. Use the 'collapse' method of the combobox instead, which does the necessary book-keeping. Signed-off-by: Dominik Csapak --- src/form/ComboGrid.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js index ba3ce40..29c3d26 100644 --- a/src/form/ComboGrid.js +++ b/src/form/ComboGrid.js @@ -290,7 +290,7 @@ Ext.define('Proxmox.form.ComboGrid', { if (!me.multiSelect) { picker.on('itemclick', function(sm, record) { if (picker.getSelection()[0] === record) { - picker.hide(); + me.collapse(); } }); } -- 2.30.2