From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 596BF96CC0 for ; Thu, 26 Jan 2023 15:31:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 41FB424C00 for ; Thu, 26 Jan 2023 15:31:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 26 Jan 2023 15:31:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 316B6465AB for ; Thu, 26 Jan 2023 15:31:53 +0100 (CET) From: Leo Nunner To: pve-devel@lists.proxmox.com Date: Thu, 26 Jan 2023 15:31:25 +0100 Message-Id: <20230126143127.151018-1-l.nunner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.426 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_HI -5 Sender listed at https://www.dnswl.org/, high trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [helpers.pm, aliases.pm, proxmox.com, groups.pm, ipset.pm] Subject: [pve-devel] [PATCH v2 firewall] fix #4414: automatically rename usages of aliases and IPsets X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jan 2023 14:31:54 -0000 This patch depends on my previous patch removing capitalization restrictions [1]. Changes from v1: - factor in feedback from v1 - fix issues that arose from renaming objects and changing their capitalization. This is a separate patch, since it would exceed the scope of this one. Rebased accordingly. Note that this patch depends on _all_ the patches in [1], so also the optional one. In case that isn't needed, I'll rebase this patch. [1] https://lists.proxmox.com/pipermail/pve-devel/2023-January/055596.html firewall: Leo Nunner (2): allow updating an alias without providing a CIDR fix #4414: automatically rename usages of aliases and IPsets src/PVE/API2/Firewall/Aliases.pm | 53 ++++++++++++++++++++++++++++--- src/PVE/API2/Firewall/Groups.pm | 54 ++++++-------------------------- src/PVE/API2/Firewall/IPSet.pm | 47 +++++++++++++++++++++++++-- src/PVE/Firewall/Helpers.pm | 33 +++++++++++++++++++ 4 files changed, 136 insertions(+), 51 deletions(-) -- 2.30.2