From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 076FA96BF7 for ; Thu, 26 Jan 2023 15:30:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8E44A2473C for ; Thu, 26 Jan 2023 15:30:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 26 Jan 2023 15:30:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9F394465B6 for ; Thu, 26 Jan 2023 15:30:47 +0100 (CET) From: Leo Nunner To: pve-devel@lists.proxmox.com Date: Thu, 26 Jan 2023 15:30:15 +0100 Message-Id: <20230126143020.150338-1-l.nunner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [aliases.pm, rules.pm, cluster.pm, ipset.pm, firewall.pm, vm.pm, groups.pm] Subject: [pve-devel] [PATCH firewall manager] Make firewall config case-insensitive X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jan 2023 14:30:51 -0000 Until now, the firewall config was quite inconsistent when it came to capitalization; groups and ipsets were only allowed in lower-case, while aliases were allowed to retain the original capitalization. This patch removes all of these restrictions, and instead keeps the original user-supplied values for groups, ipsets and aliases. Furthermore, variable naming for rename parameters was cleaned up (due to touching these lines anyway) and the docs for them were clarified a bit. Optionally, this patch also merges group_comments and ipset_comments with their groups/ipsets into one unified structure. firewall: Leo Nunner (4): api: factor out renaming parameters to more descriptive names docs: clarify usage of 'rename' parameters config: make groups, IPSets and aliases case-insensitive config: combine group/ipset and their comments src/PVE/API2/Firewall/Aliases.pm | 42 +++++++------ src/PVE/API2/Firewall/Cluster.pm | 2 +- src/PVE/API2/Firewall/Groups.pm | 63 +++++++++---------- src/PVE/API2/Firewall/IPSet.pm | 54 ++++++++-------- src/PVE/API2/Firewall/Rules.pm | 4 +- src/PVE/API2/Firewall/VM.pm | 2 +- src/PVE/Firewall.pm | 105 +++++++++++++++++-------------- 7 files changed, 144 insertions(+), 128 deletions(-) manager: Leo Nunner (1): ui: the API doesn't pass 'name' for aliases anymore www/manager6/grid/FirewallAliases.js | 1 + 1 file changed, 1 insertion(+) -- 2.30.2