From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 51C1096B83 for ; Thu, 26 Jan 2023 11:47:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2B55121D2A for ; Thu, 26 Jan 2023 11:47:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 26 Jan 2023 11:47:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A7498465B7 for ; Thu, 26 Jan 2023 11:47:13 +0100 (CET) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Thu, 26 Jan 2023 11:47:11 +0100 Message-Id: <20230126104711.377316-3-l.wagner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230126104711.377316-1-l.wagner@proxmox.com> References: <20230126104711.377316-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.364 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_HI -5 Sender listed at https://www.dnswl.org/, high trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v3 manager 2/2] ui: backup: replication: replace non-clickable checkbox with icons X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jan 2023 10:47:45 -0000 >From a usability view, having a checkbox that is not clickable is pretty misleading, especially if the visual style is exactly the same as in other places in the UI where the checkbox is functional. Signed-off-by: Lukas Wagner --- www/manager6/dc/Backup.js | 6 ++---- www/manager6/grid/Replication.js | 7 ++++--- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index 9d305984..4d12e802 100644 --- a/www/manager6/dc/Backup.js +++ b/www/manager6/dc/Backup.js @@ -785,11 +785,9 @@ Ext.define('PVE.dc.BackupView', { header: gettext('Enabled'), width: 80, dataIndex: 'enabled', - xtype: 'checkcolumn', + align: 'center', + renderer: Proxmox.Utils.renderEnabledIcon, sortable: true, - disabled: true, - disabledCls: 'x-item-enabled', - stopSelection: false, }, { header: gettext('ID'), diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js index b17288b9..1e4e00fc 100644 --- a/www/manager6/grid/Replication.js +++ b/www/manager6/grid/Replication.js @@ -279,11 +279,12 @@ Ext.define('PVE.grid.ReplicaView', { me.columns = [ { - text: gettext('Enabled'), + header: gettext('Enabled'), + width: 80, dataIndex: 'enabled', - xtype: 'checkcolumn', + align: 'center', + renderer: Proxmox.Utils.renderEnabledIcon, sortable: true, - disabled: true, }, { text: 'ID', -- 2.30.2