From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2634396133 for ; Mon, 23 Jan 2023 14:17:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 063DB2761C for ; Mon, 23 Jan 2023 14:17:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 23 Jan 2023 14:17:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7ADCE45C50 for ; Mon, 23 Jan 2023 14:17:37 +0100 (CET) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Mon, 23 Jan 2023 14:17:34 +0100 Message-Id: <20230123131735.400368-2-l.wagner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230123131735.400368-1-l.wagner@proxmox.com> References: <20230123131735.400368-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 widget-toolkit 1/1] repo view: replace non-clickable checkbox with icons X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2023 13:17:39 -0000 >From a usability view, having a checkbox that is not clickable is pretty misleading, especially if the visual style is exactly the same as in other places in the UI where the checkbox is functional. Signed-off-by: Lukas Wagner --- src/Utils.js | 6 ++++++ src/node/APTRepositories.js | 8 ++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/Utils.js b/src/Utils.js index ef0c2b8..5397fd9 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -100,6 +100,11 @@ utilities: { return value; }, + render_enabled_icon: function(value) { + let icon = value ? 'fa-check' : 'fa-minus'; + return ``; + }, + language_array: function() { let data = [['__default__', Proxmox.Utils.render_language('')]]; Ext.Object.each(Proxmox.Utils.language_map, function(key, value) { @@ -145,6 +150,7 @@ utilities: { return value ? Proxmox.Utils.enabledText : Proxmox.Utils.disabledText; }, + format_expire: function(date) { if (!date) { return Proxmox.Utils.neverText; diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js index ce8f718..c6b45a2 100644 --- a/src/node/APTRepositories.js +++ b/src/node/APTRepositories.js @@ -239,11 +239,11 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', { columns: [ { - xtype: 'checkcolumn', header: gettext('Enabled'), - dataIndex: 'Enabled', - listeners: { - beforecheckchange: () => false, // veto, we don't want to allow inline change - to subtle + dataindex: 'Enabled', + align: 'center', + renderer: function(enabled, cell, record) { + return Proxmox.Utils.render_enabled_icon(record.data.Enabled); }, width: 90, }, -- 2.30.2