From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C9436960DF for ; Mon, 23 Jan 2023 10:52:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A82F024C53 for ; Mon, 23 Jan 2023 10:52:37 +0100 (CET) Received: from sara.proxmox.com (unknown [94.136.29.99]) by firstgate.proxmox.com (Proxmox) with ESMTP for ; Mon, 23 Jan 2023 10:52:36 +0100 (CET) Received: by sara.proxmox.com (Postfix, from userid 1000) id 6C8EF423F4; Mon, 23 Jan 2023 10:52:36 +0100 (CET) From: Moayad Almalat To: pve-devel@lists.proxmox.com Date: Mon, 23 Jan 2023 10:52:35 +0100 Message-Id: <20230123095235.156177-1-m.almalat@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.339 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pvesh.pm] Subject: [pve-devel] [PATCH v2 manager] fix #3037: include the split_list to shell_qoute X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2023 09:52:37 -0000 Based to the suggestion of Wolfgang, in regard to `split_list()`, I converted the `split_list()` to `split(/\0/, $param->{$key});` this will split the `$param->{$key}` null characters and push each element to the `$args` array along with the key value. changes since v1: * get rid of the `use PVE::Tools qw(split_list);` since not need it anymore. * replace the split_list to split(/\0/). Signed-off-by: Moayad Almalat --- PVE/CLI/pvesh.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/CLI/pvesh.pm b/PVE/CLI/pvesh.pm index 370fdb0e..9acf292a 100755 --- a/PVE/CLI/pvesh.pm +++ b/PVE/CLI/pvesh.pm @@ -106,7 +106,7 @@ sub proxy_handler { my $args = []; foreach my $key (keys %$param) { next if $key eq 'quiet' || $key eq 'output-format'; # just to be sure - push @$args, "--$key", $param->{$key}; + push @$args, "--$key", $_ for split(/\0/, $param->{$key}); } my $remcmd = ['ssh', '-o', 'BatchMode=yes', "root\@$remip", -- 2.30.2