From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 215C896065 for ; Mon, 23 Jan 2023 10:46:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EEE3724B10 for ; Mon, 23 Jan 2023 10:46:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 23 Jan 2023 10:46:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7382945CB3 for ; Mon, 23 Jan 2023 10:46:41 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 23 Jan 2023 10:46:38 +0100 Message-Id: <20230123094638.63892-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH qemu-server] schema: memory: be precise that unit is binary prefix X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2023 09:46:43 -0000 In the web UI, this was fixed years ago by pve-manager commit c11c4a40 ("fix #1631: change units to binary prefix"). Quickly checked with the 'query-memory-size-summary' QMP command that this is actually the case. Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 99242d54..6a29d1bf 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -342,7 +342,7 @@ my $confdesc = { memory => { optional => 1, type => 'integer', - description => "Amount of RAM for the VM in MB. This is the maximum available memory when" + description => "Amount of RAM for the VM in MiB. This is the maximum available memory when" ." you use the balloon device.", minimum => 16, default => 512, @@ -350,7 +350,7 @@ my $confdesc = { balloon => { optional => 1, type => 'integer', - description => "Amount of target RAM for the VM in MB. Using zero disables the ballon driver.", + description => "Amount of target RAM for the VM in MiB. Using zero disables the ballon driver.", minimum => 0, }, shares => { -- 2.30.2