From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1984F95C58 for ; Fri, 20 Jan 2023 09:47:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EAE335B04 for ; Fri, 20 Jan 2023 09:47:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 20 Jan 2023 09:47:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 385774551B for ; Fri, 20 Jan 2023 09:47:16 +0100 (CET) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Fri, 20 Jan 2023 09:47:10 +0100 Message-Id: <20230120084710.94577-1-l.wagner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.136 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: fix search for 'Guests without Backup' window X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2023 08:47:17 -0000 In JS, a `for (const a in <...>)` loop iterates over indices, not over values. To iterate over values, `for (const a of <..>)` has to be used. Furthermore, filtering by ID did not work properly, since the property is called `vmid`, not `id`. Signed-off-by: Lukas Wagner --- www/manager6/dc/BackupJobDetail.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/dc/BackupJobDetail.js b/www/manager6/dc/BackupJobDetail.js index c82f50f4..c4683a47 100644 --- a/www/manager6/dc/BackupJobDetail.js +++ b/www/manager6/dc/BackupJobDetail.js @@ -460,7 +460,7 @@ Ext.define('PVE.dc.BackedGuests', { me.store.clearFilter(true); me.store.filterBy(function(record) { let data = record.data; - for (const property in ['name', 'id', 'type']) { + for (const property of ['name', 'vmid', 'type']) { if (data[property] === null) { continue; } -- 2.30.2