From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 80E0595A18 for ; Thu, 19 Jan 2023 11:25:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 628552A7CB for ; Thu, 19 Jan 2023 11:25:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 19 Jan 2023 11:25:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 03FC7448E5 for ; Thu, 19 Jan 2023 11:25:44 +0100 (CET) From: Christian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 19 Jan 2023 11:25:03 +0100 Message-Id: <20230119102504.26062-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [host.pm, vm.pm, helpers.pm] Subject: [pve-devel] [PATCH v3 firewall 0/1] Optional `since` and `until` firewall log filtering X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2023 10:25:45 -0000 This patch introduces 2 optional api parameters `since` and `until` to firewall log endpoints, in order to make them filterable. Filtering of the firewall logs is performed by a callback function. --- Changes since RFC version: - common: Use callback function filter instead of `since` `until` params - common: code reuse for `dump_logfile` and `dump_fw_logfile` - firewall: Style fixes and use of callback function Changes since v1: - common: Store parameters needed for multiple `dump_logfile_by_filehandle` invocations in state hash. - common: Introduce `final` parameter to signal last invocation to `dump_logfile_by_filehandle`. - firewall: Moved `dump_fw_logfile` to firewall helper functions - firewall: Refactor of finding rotated logfiles by use of `dir_glob_foreach` and fixed regex. - firewall: Avoid error if opening logfile failes with ENOENT - Whitespace cleanup Changes since v2: - use `qr//` syntax for regex in filter callback - deduplicate code by moving common filter logic to `dump_fw_logfile` - Fix off by one error in `filecount` for finding final file Christian Ebner (1): api: Add optional parameters `since` and `until` for timestamp filter src/PVE/API2/Firewall/Host.pm | 16 ++++++- src/PVE/API2/Firewall/VM.pm | 26 ++++++++++-- src/PVE/Firewall/Helpers.pm | 78 +++++++++++++++++++++++++++++++++++ 3 files changed, 115 insertions(+), 5 deletions(-) -- 2.30.2