From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 81BF89572C for ; Wed, 18 Jan 2023 14:13:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5897620244 for ; Wed, 18 Jan 2023 14:13:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 18 Jan 2023 14:13:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 956B84511F for ; Wed, 18 Jan 2023 14:13:05 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 18 Jan 2023 14:13:01 +0100 Message-Id: <20230118131303.2892050-7-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230118131303.2892050-1-d.csapak@proxmox.com> References: <20230118131303.2892050-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 4/6] ui: storage/IScsiInputPanel: modernize, cleanup & improve panel X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2023 13:13:38 -0000 using cbind + pmxDisplayEditField, getting rid of initComponent Disables the target selector until a portal is entered. For this, we currently cannot use the pmxDisplayEditField, since that disabled/enables the fields automatically based on 'editable'. Also setting buffer for the portal entry change handler to 500ms (so that we don't query the backend that often) Signed-off-by: Dominik Csapak --- www/manager6/storage/IScsiEdit.js | 90 +++++++++++++++++-------------- 1 file changed, 51 insertions(+), 39 deletions(-) diff --git a/www/manager6/storage/IScsiEdit.js b/www/manager6/storage/IScsiEdit.js index 6a1e4aeb5..314882b44 100644 --- a/www/manager6/storage/IScsiEdit.js +++ b/www/manager6/storage/IScsiEdit.js @@ -71,6 +71,7 @@ Ext.define('PVE.storage.IScsiScan', { Ext.define('PVE.storage.IScsiInputPanel', { extend: 'PVE.panel.StorageBase', + mixins: ['Proxmox.Mixin.CBind'], onlineHelp: 'storage_open_iscsi', @@ -88,50 +89,61 @@ Ext.define('PVE.storage.IScsiInputPanel', { this.callParent([values]); }, - initComponent: function() { - let me = this; + column1: [ + { + xtype: 'pmxDisplayEditField', + cbind: { + editable: '{isCreate}', + }, - me.column1 = [ - { - xtype: me.isCreate ? 'textfield' : 'displayfield', - name: 'portal', - value: '', - fieldLabel: 'Portal', - allowBlank: false, + name: 'portal', + value: '', + fieldLabel: 'Portal', + allowBlank: false, + + editConfig: { listeners: { - change: function(f, value) { - if (me.isCreate) { - let exportField = me.down('field[name=target]'); - exportField.setPortal(value); - exportField.setValue(''); - } + change: { + fn: function(f, value) { + let panel = this.up('inputpanel'); + let exportField = panel.lookup('iScsiTargetScan'); + if (exportField) { + exportField.setDisabled(!value); + exportField.setPortal(value); + exportField.setValue(''); + } + }, + buffer: 500, }, }, }, - Ext.createWidget(me.isCreate ? 'pveIScsiScan' : 'displayfield', { - readOnly: !me.isCreate, - name: 'target', - value: '', - fieldLabel: gettext('Target'), - allowBlank: false, - reference: 'iScsiTargetScan', - listeners: { - nodechanged: function(value) { - me.lookup('storageNodeRestriction').setValue(value); - }, - }, - }), - ]; - - me.column2 = [ - { - xtype: 'checkbox', - name: 'luns', - checked: true, - fieldLabel: gettext('Use LUNs directly'), + }, + { + cbind: { + xtype: (get) => get('isCreate') ? 'pveIScsiScan' : 'displayfield', + readOnly: '{!isCreate}', + disabled: '{isCreate}', }, - ]; - me.callParent(); - }, + name: 'target', + value: '', + fieldLabel: gettext('Target'), + allowBlank: false, + reference: 'iScsiTargetScan', + listeners: { + nodechanged: function(value) { + this.up('inputpanel').lookup('storageNodeRestriction').setValue(value); + }, + }, + }, + ], + + column2: [ + { + xtype: 'checkbox', + name: 'luns', + checked: true, + fieldLabel: gettext('Use LUNs directly'), + }, + ], }); -- 2.30.2