From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 01C0A95702 for ; Wed, 18 Jan 2023 14:13:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C30E8202DE for ; Wed, 18 Jan 2023 14:13:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 18 Jan 2023 14:13:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9963645121 for ; Wed, 18 Jan 2023 14:13:05 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 18 Jan 2023 14:13:00 +0100 Message-Id: <20230118131303.2892050-6-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230118131303.2892050-1-d.csapak@proxmox.com> References: <20230118131303.2892050-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -1.236 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% ENA_SUBJ_ODD_CASE 2.6 Subject has odd case KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 3/6] ui: storage/LvmThinInputPanel: modernize & cleanup code X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2023 13:13:10 -0000 using cbind + pmxDisplayEditField, getting rid of the initComponent Signed-off-by: Dominik Csapak --- www/manager6/storage/LvmThinEdit.js | 83 ++++++++++++----------------- 1 file changed, 35 insertions(+), 48 deletions(-) diff --git a/www/manager6/storage/LvmThinEdit.js b/www/manager6/storage/LvmThinEdit.js index 0c288bb04..ece5512b0 100644 --- a/www/manager6/storage/LvmThinEdit.js +++ b/www/manager6/storage/LvmThinEdit.js @@ -124,67 +124,56 @@ Ext.define('PVE.storage.BaseVGSelector', { Ext.define('PVE.storage.LvmThinInputPanel', { extend: 'PVE.panel.StorageBase', + mixins: ['Proxmox.Mixin.CBind'], onlineHelp: 'storage_lvmthin', - initComponent: function() { - let me = this; - - me.column1 = []; + column1: [ + { + xtype: 'pmxDisplayEditField', + cbind: { + editable: '{isCreate}', + }, - let vgnameField = Ext.createWidget(me.isCreate ? 'textfield' : 'displayfield', { name: 'vgname', - hidden: !!me.isCreate, - disabled: !!me.isCreate, - value: '', fieldLabel: gettext('Volume group'), - allowBlank: false, - }); - let thinpoolField = Ext.createWidget(me.isCreate ? 'textfield' : 'displayfield', { - name: 'thinpool', - hidden: !!me.isCreate, - disabled: !!me.isCreate, - value: '', - fieldLabel: gettext('Thin Pool'), - allowBlank: false, - }); - - if (me.isCreate) { - me.column1.push(Ext.create('PVE.storage.BaseVGSelector', { - name: 'vgname', - fieldLabel: gettext('Volume group'), - reference: 'volumeGroupSelector', + editConfig: { + xtype: 'pveBaseVGSelector', listeners: { nodechanged: function(value) { - me.lookup('thinPoolSelector').setNodeName(value); - me.lookup('storageNodeRestriction').setValue(value); + let panel = this.up('inputpanel'); + panel.lookup('thinPoolSelector').setNodeName(value); + panel.lookup('storageNodeRestriction').setValue(value); }, change: function(f, value) { - if (me.isCreate) { - let vgField = me.lookup('thinPoolSelector'); + let vgField = this.up('inputpanel').lookup('thinPoolSelector'); + if (vgField) { + vgField.setDisabled(!value); vgField.setVG(value); vgField.setValue(''); } }, }, - })); - - me.column1.push(Ext.create('PVE.storage.TPoolSelector', { - name: 'thinpool', - fieldLabel: gettext('Thin Pool'), - reference: 'thinPoolSelector', - allowBlank: false, - })); - } - - me.column1.push(vgnameField); + }, + }, + { + xtype: 'pmxDisplayEditField', + cbind: { + editable: '{isCreate}', + }, - me.column1.push(thinpoolField); + name: 'thinpool', + fieldLabel: gettext('Thin Pool'), + allowBlank: false, - // here value is an array, - // while before it was a string - me.column1.push({ + editConfig: { + xtype: 'pveTPSelector', + reference: 'thinPoolSelector', + disabled: true, + }, + }, + { xtype: 'pveContentTypeSelector', cts: ['images', 'rootdir'], fieldLabel: gettext('Content'), @@ -192,10 +181,8 @@ Ext.define('PVE.storage.LvmThinInputPanel', { value: ['images', 'rootdir'], multiSelect: true, allowBlank: false, - }); + }, + ], - me.column2 = []; - - me.callParent(); - }, + column2: [], }); -- 2.30.2