From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 76172955F4 for ; Wed, 18 Jan 2023 14:13:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5207920242 for ; Wed, 18 Jan 2023 14:13:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 18 Jan 2023 14:13:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AA1814508B for ; Wed, 18 Jan 2023 14:13:04 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 18 Jan 2023 14:12:58 +0100 Message-Id: <20230118131303.2892050-4-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230118131303.2892050-1-d.csapak@proxmox.com> References: <20230118131303.2892050-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -1.236 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% ENA_SUBJ_ODD_CASE 2.6 Subject has odd case KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 1/6] ui: StorageScanNodeSelector: use null as empty value X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2023 13:13:08 -0000 otherwise it can happen that there as additional change event from null to '', even though the value did not change Signed-off-by: Dominik Csapak --- www/manager6/form/StorageScanNodeSelector.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/www/manager6/form/StorageScanNodeSelector.js b/www/manager6/form/StorageScanNodeSelector.js index d6c9508a1..b2e013e9c 100644 --- a/www/manager6/form/StorageScanNodeSelector.js +++ b/www/manager6/form/StorageScanNodeSelector.js @@ -9,7 +9,7 @@ Ext.define('PVE.form.StorageScanNodeSelector', { disallowedNodes: undefined, autoSelect: false, submitValue: false, - value: "", + value: null, autoEl: { tag: 'div', 'data-qtip': gettext('Scan for available storages on the selected node'), @@ -18,14 +18,16 @@ Ext.define('PVE.form.StorageScanNodeSelector', { clear: { handler: function() { let me = this; - me.setValue(""); + me.setValue(null); }, }, }, + emptyText: Proxmox.NodeName, + setValue: function(value) { let me = this; me.callParent([value]); - me.triggers.clear.setVisible(value !== ""); + me.triggers.clear.setVisible(!!value); }, }); -- 2.30.2