From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 73DA19572A for <pve-devel@lists.proxmox.com>; Wed, 18 Jan 2023 14:13:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 545AD20294 for <pve-devel@lists.proxmox.com>; Wed, 18 Jan 2023 14:13:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Wed, 18 Jan 2023 14:13:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9809045101 for <pve-devel@lists.proxmox.com>; Wed, 18 Jan 2023 14:13:04 +0100 (CET) From: Dominik Csapak <d.csapak@proxmox.com> To: pve-devel@lists.proxmox.com Date: Wed, 18 Jan 2023 14:12:55 +0100 Message-Id: <20230118131303.2892050-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit/pve-manager] move node selection into combogrid X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 18 Jan 2023 13:13:38 -0000 instead of having it as a seperate input on storage creation. This aims to reduce confusion about what it exactly is and how it interacts with the rest of the input fields. With this series, it sits in a toolbar of the relevant dropdown, which were converted to combogrids. The selection box is only shown if the number of nodes in the cluster is greater than one. for accomodating the toolbar, we have to make 2 slight adaptions to the combogrid patch 3,4,5,6 of pve-manager are mostly cleanups and are not strictly necessary for this series to work, but since i touched the files anyway, i converted them to our 'modern' js style The cleanups come after the change, because thats the order in which i wrote it. If wanted i can send the cleanups seperately for the current master, and rebase the changes for the node selection on top. proxmox-widget-toolkit: Dominik Csapak (2): ComboGrid: use the grids view for the error message ComboGrid: make height for the error configurable src/form/ComboGrid.js | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) pve-manager: Dominik Csapak (6): ui: StorageScanNodeSelector: use null as empty value ui: storage: move node scan selector inside combobox ui: storage/LvmThinInputPanel: modernize & cleanup code ui: storage/IScsiInputPanel: modernize, cleanup & improve panel ui: storage/ZFSPoolInputPanel: modernize & cleanup code ui: storage/LVMInputPanel: modernize & cleanup code www/manager6/form/ComboBoxSetStoreNode.js | 45 +++- www/manager6/form/StorageScanNodeSelector.js | 8 +- www/manager6/storage/IScsiEdit.js | 129 +++++++----- www/manager6/storage/LVMEdit.js | 209 +++++++++++-------- www/manager6/storage/LvmThinEdit.js | 150 +++++++------ www/manager6/storage/ZFSPoolEdit.js | 100 +++++---- 6 files changed, 361 insertions(+), 280 deletions(-) -- 2.30.2