From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A6BCF95650 for ; Wed, 18 Jan 2023 13:21:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 835091FB39 for ; Wed, 18 Jan 2023 13:21:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 18 Jan 2023 13:21:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 972B34508B for ; Wed, 18 Jan 2023 13:21:13 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 18 Jan 2023 13:21:08 +0100 Message-Id: <20230118122109.304270-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230118122109.304270-1-f.ebner@proxmox.com> References: <20230118122109.304270-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 1/2] swtpm: enable logging X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2023 12:21:44 -0000 AFAICT, previously, errors from swtpm would not show up in any logs, because they were just printed to the stderr of the daemonized invocation here. The 'truncate' option is not used, so that the log is not immediately lost when a new instance is started. This increases the chance that the relevant errors are still present when requesting the log from a user. Log level 1 contains the most relevant errors and seems to be quiet for working-as-expected invocations. Log level 2 already includes logging full TPM commands, some of which are 1024 bytes long. Thus, log level 1 was chosen. Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index c2f5726e..97d60e2d 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3263,6 +3263,8 @@ sub start_swtpm { "file=$paths->{pid}", "--terminate", # terminate on QEMU disconnect "--daemon", + "--log", + "file=/run/qemu-server/$vmid-swtpm.log,level=1", ]; push @$emulator_cmd, "--tpm2" if $tpm->{version} eq 'v2.0'; run_command($emulator_cmd, outfunc => sub { print $1; }); -- 2.30.2