From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8761695096 for ; Tue, 17 Jan 2023 13:18:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6996EB530 for ; Tue, 17 Jan 2023 13:17:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 17 Jan 2023 13:17:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 60E1C44CB5 for ; Tue, 17 Jan 2023 13:17:32 +0100 (CET) From: Matthias Heiserer To: pve-devel@lists.proxmox.com Date: Tue, 17 Jan 2023 13:17:22 +0100 Message-Id: <20230117121723.65246-1-m.heiserer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.413 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, me.drive, proxmox.com] Subject: [pve-devel] [PATCH manager 1/2] GUI: efi disk: use correct version with aarch64 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2023 12:18:03 -0000 Sets the EFI version to 2m when arch=aarch64. When the VM has arch=aarch64, creating an EFI disk failed with "Can't use an undefined value as an ARRAY reference at /usr/share/perl5/PVE/QemuServer.pm line 3382. (500)" That's because we only have EFI 2m available for aarch64. Reported in the forum: https://forum.proxmox.com/threads/121160/ Signed-off-by: Matthias Heiserer --- www/manager6/qemu/HDEfi.js | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HDEfi.js b/www/manager6/qemu/HDEfi.js index a8ca8f56..ef3092a6 100644 --- a/www/manager6/qemu/HDEfi.js +++ b/www/manager6/qemu/HDEfi.js @@ -26,7 +26,7 @@ Ext.define('PVE.qemu.EFIDiskInputPanel', { // always default to newer 4m type with secure boot support, if we're // adding a new EFI disk there can't be any old state anyway - me.drive.efitype = '4m'; + me.drive.efitype = me.config.useOldVersion ? '2m' : '4m'; me.drive['pre-enrolled-keys'] = values.preEnrolledKeys; delete values.preEnrolledKeys; @@ -103,15 +103,24 @@ Ext.define('PVE.qemu.EFIDiskEdit', { throw "no node name specified"; } - me.items = [{ + const efiInputPanel = Ext.create({ xtype: 'pveEFIDiskInputPanel', onlineHelp: 'qm_bios_and_uefi', confid: me.confid, nodename: nodename, usesEFI: me.usesEFI, isCreate: true, - }]; + useOldVersion: false, + }); + me.items = [efiInputPanel]; me.callParent(); + + me.load({ + success: function(response) { + const data = response.result.data; + efiInputPanel.config.useOldVersion = data.arch === 'aarch64'; + }, + }); }, }); -- 2.30.2