From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3E8AC94271 for ; Tue, 10 Jan 2023 14:41:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1F036AF20 for ; Tue, 10 Jan 2023 14:41:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 10 Jan 2023 14:41:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BABEF42E5E for ; Tue, 10 Jan 2023 14:41:40 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 10 Jan 2023 14:41:37 +0100 Message-Id: <20230110134137.185361-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH qemu-server] fix #4435: devices list: avoid error for undefined value X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2023 13:41:42 -0000 When $d->{'pci_bridge'}->{devices} is undef, @-dereferencing it will die with: > Can't use an undefined value as an ARRAY reference This can happen (at least) when the VM is in 'prelaunch' state. The QAPI definition for '@PciBridgeInfo' also declares the 'devices' member as optional. Before commit 721624b ("collect device list for nested pci-bridges"), there was no issue, because $d->{'pci_bridge'}->{devices} was used in foreach, so auto-vivified if undef. Fixes: f721624b ("collect device list for nested pci-bridges") Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 39fc6b09..4292da74 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -4194,7 +4194,7 @@ sub vm_devices_list { my $to_check = []; for my $d (@$devices_to_check) { $devices->{$d->{'qdev_id'}} = 1 if $d->{'qdev_id'}; - next if !$d->{'pci_bridge'}; + next if !$d->{'pci_bridge'} || !$d->{'pci_bridge'}->{devices}; $devices->{$d->{'qdev_id'}} += scalar(@{$d->{'pci_bridge'}->{devices}}); push @$to_check, @{$d->{'pci_bridge'}->{devices}}; -- 2.30.2