From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AE61F93679 for ; Thu, 5 Jan 2023 11:09:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8065B27E82 for ; Thu, 5 Jan 2023 11:09:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 5 Jan 2023 11:09:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 80B4544D9E for ; Thu, 5 Jan 2023 11:09:30 +0100 (CET) From: Daniel Tschlatscher To: pve-devel@lists.proxmox.com Date: Thu, 5 Jan 2023 11:08:31 +0100 Message-Id: <20230105100837.195520-1-d.tschlatscher@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.111 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [helpers.pm, jsonschema.pm, qemuserver.pm, qemu.pm] Subject: [pve-devel] [PATCH common/qemu-server/manager v4] fix #3502: VM start timeout config parameter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2023 10:09:32 -0000 This patch series adds a an option to specify a timeout value in the config for starting VMs. The minimum is 0 seconds, which disables the timeout completely. The maximum is 86400 seconds, equivalent to 1 day. The timeout value can also be passed via the CLI, which always overrides the setting. If no value for timeout is passed, the timeout will either be read from the config, or if unavailable, chosen heuristically like before, with a default of 30 seconds in most cases. For this, a new property string called "startoptions" is added. Currently only the VM start timeout is configurable with it. Changes from v3 * Minor code cleanup * Addressed an edge case concerning the killing of a lingering VM to not accidentally kill an unrelated process Thanks to Fabian for the review and suggestions! pve-common: Daniel Tschlatscher (1): VM start timeout config parameter src/PVE/JSONSchema.pm | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) qemu-server: Daniel Tschlatscher (4): expose VM start timeout config setting in API await and kill lingering KVM thread when VM start reaches timeout re-check if VM is running and PID for KILL after timeout make the timeout value editable when the VM is locked PVE/API2/Qemu.pm | 27 ++++++++++++++++++++++++++ PVE/QemuServer.pm | 41 +++++++++++++++++++++++++++++++-------- PVE/QemuServer/Helpers.pm | 4 ++++ 3 files changed, 64 insertions(+), 8 deletions(-) pve-manager: Daniel Tschlatscher (1): VM start Timeout "Options" parameter in the GUI www/manager6/qemu/Options.js | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) -- 2.30.2