From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2EA2D934A5 for ; Wed, 4 Jan 2023 13:58:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0AEC31EA23 for ; Wed, 4 Jan 2023 13:57:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 4 Jan 2023 13:57:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9524E4508E for ; Wed, 4 Jan 2023 13:57:38 +0100 (CET) From: Daniel Tschlatscher To: pve-devel@lists.proxmox.com Date: Wed, 4 Jan 2023 13:56:32 +0100 Message-Id: <20230104125635.421634-1-d.tschlatscher@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.117 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager/widget-toolkit v6] fix: #3971 Tasklog download button X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2023 12:58:10 -0000 This patch series' aim is to add a download button in the tasklog- viewer GUI so that users may access the tasklog more easily. (The tasklog-viewer only displays 50 lines at a time) Instead of suddenly returning a file stream when the 'limit' parameter is set to 0, now, a new parameter 'download' needs to be passed. This parameter is mutually exclusive with the other parameters. With the backend patches for pmg and pbs already being applied, these are the final patches to make the download work. Therefore, this revision only contains the missing backend patch for PVE and the GUI patches in the widget-toolkit for the button in the TaskViewer. Changes from v5: * The last version used parameter 'limit=0' instead of 'download=1' for the download URL. * Cleaned up one NIT in manager. Thanks to sterzy for the review! pve-manager: Daniel Tschlatscher (1): make task log downloadable in the PVE manager backend PVE/API2/Tasks.pm | 49 ++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 42 insertions(+), 7 deletions(-) proxmox-widget-toolkit: Daniel Tschlatscher (2): Source file download call in central function add task log download button in TaskViewer src/Utils.js | 13 +++++++++++++ src/window/FileBrowser.js | 11 +++++------ src/window/TaskViewer.js | 17 +++++++++++++++-- 3 files changed, 33 insertions(+), 8 deletions(-) -- 2.30.2