From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7FF7092E94 for ; Mon, 2 Jan 2023 17:04:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 63E823050 for ; Mon, 2 Jan 2023 17:04:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 2 Jan 2023 17:04:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1040A45057 for ; Mon, 2 Jan 2023 17:04:49 +0100 (CET) From: Leo Nunner To: pve-devel@lists.proxmox.com Date: Mon, 2 Jan 2023 17:04:36 +0100 Message-Id: <20230102160438.180285-1-l.nunner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 storage docs] Allow overrides for default directories X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2023 16:04:56 -0000 This patch adds a parameter to the storage configuration that allows the default directory structure to be overridden. For now, I allowed the parameter for the directory, CIFS and NFS plugins. I tested the following things: - Create VMs/CTs - Upload ISOs/container templates - Create/restore backups - Upload snippets - Move images between storages with different configurations All of which posed no problems with the UI and were put into the correct (custom) location. I also did migrations with a few different configurations, which also worked correctly. Changes from v1: - Change parameter verification from pve-volume-id to a custom format that also verifies the validity of the path and the given vtype. storage: Leo Nunner (1): config: add overrides for default directory locations PVE/Storage/CIFSPlugin.pm | 1 + PVE/Storage/DirPlugin.pm | 1 + PVE/Storage/NFSPlugin.pm | 1 + PVE/Storage/Plugin.pm | 49 +++++++++++++++++++++++++++++++++++---- test/get_subdir_test.pm | 7 ++++++ 5 files changed, 55 insertions(+), 4 deletions(-) docs: Leo Nunner (1): docs: document 'dirs' parameter for directory storage pve-storage-cifs.adoc | 4 ++++ pve-storage-dir.adoc | 19 ++++++++++++++----- pve-storage-nfs.adoc | 4 ++++ 3 files changed, 22 insertions(+), 5 deletions(-) -- 2.30.2