From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A3AEE9113A for ; Tue, 20 Dec 2022 11:31:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 821383153D for ; Tue, 20 Dec 2022 11:30:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 20 Dec 2022 11:30:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6A21F44380 for ; Tue, 20 Dec 2022 11:30:54 +0100 (CET) From: Stefan Sterz To: pve-devel@lists.proxmox.com Date: Tue, 20 Dec 2022 11:30:36 +0100 Message-Id: <20221220103037.890813-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, proxmox.com] Subject: [pve-devel] [PATCH qemu-server v4 1/2] cd rom handling: return a clearer error when there is no cd rom drive X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2022 10:31:25 -0000 when a vm is configured to use a physical cd rom drive but there is no such drive a cryptic "uninitialized value" error is thrown. this is due to `$path` being undefined in `sub print_drive_commandline_full`. warn that no cd rom drive is available instead. note that the error was cosmetic as the vm would start just fine. forum thread: https://forum.proxmox.com/threads/119592/ Signed-off-by: Stefan Sterz --- changes from v3 (thanks @ Thomas Lamprecht): * use `log_warn` instead of `warn` * dont return results of assignments changes from v2 (thanks @ Fiona Ebner): * added newline to message * cache the fact that no drive is available so we warn only once * adjusted error message again changes from v1: * make the error message more concise. * use shorter forum link for better formatting in commit message (thanks @ Fiona Ebner). PVE/QemuServer.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 39fc6b0..3837bd9 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -1287,11 +1287,16 @@ sub option_exists { my $cdrom_path; sub get_cdrom_path { - return $cdrom_path if $cdrom_path; + return $cdrom_path if defined($cdrom_path); return $cdrom_path = "/dev/cdrom" if -l "/dev/cdrom"; return $cdrom_path = "/dev/cdrom1" if -l "/dev/cdrom1"; return $cdrom_path = "/dev/cdrom2" if -l "/dev/cdrom2"; + + log_warn("no physical CD-ROM available, ignoring"); + $cdrom_path = ''; + + return $cdrom_path; } sub get_iso_path { -- 2.30.2