From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1F4BC90BA7 for ; Mon, 19 Dec 2022 12:15:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E7C0226E5C for ; Mon, 19 Dec 2022 12:15:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 19 Dec 2022 12:15:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D811944685 for ; Mon, 19 Dec 2022 12:15:18 +0100 (CET) From: Stefan Sterz To: pve-devel@lists.proxmox.com Date: Mon, 19 Dec 2022 12:14:46 +0100 Message-Id: <20221219111446.219468-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server v2] cdrom handling: default to "none" if no physical drive is available X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2022 11:15:50 -0000 when a vm is configured to use the physical cd rom drive but there is no such drive a cryptic "uninitialized value" error is thrown. this is due to `$path` not being defined in `sub print_drive_commandline_full` in this case. warn that no cd rom drive is available and default back to using "none" as media instead. note that the error was basically cosmetic as the vm would start just fine. forum thread: https://forum.proxmox.com/threads/119592/ Signed-off-by: Stefan Sterz --- changes from v1: make the error message more concise. use shorter forum link for better formatting in commit message (thanks @ Fiona Ebner). PVE/QemuServer.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index dd6ea3e..d2f2094 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -1292,6 +1292,9 @@ sub get_cdrom_path { return $cdrom_path = "/dev/cdrom" if -l "/dev/cdrom"; return $cdrom_path = "/dev/cdrom1" if -l "/dev/cdrom1"; return $cdrom_path = "/dev/cdrom2" if -l "/dev/cdrom2"; + + warn "no physical cdrom available, defaulting back to 'none'"; + return ''; } sub get_iso_path { -- 2.30.2