From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F1D3E9058D for ; Fri, 16 Dec 2022 16:08:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DB4E2212C for ; Fri, 16 Dec 2022 16:08:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 16 Dec 2022 16:08:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E8F9543EB0 for ; Fri, 16 Dec 2022 16:08:29 +0100 (CET) From: Stefan Sterz To: pve-devel@lists.proxmox.com Date: Fri, 16 Dec 2022 16:08:07 +0100 Message-Id: <20221216150807.1680285-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, qemuserver.pm] Subject: [pve-devel] [PATCH qemu-server] cdrom handling: default to "none" if no physical drive is available X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Dec 2022 15:08:31 -0000 when a vm is configured to use the physical cd rom drive but there is no such drive a cryptic "uninitialized value" error is thrown. this is due to the `$path` not being defined in `sub print_drive_commandline_full` in this case. warn that no cd rom drive is available and default back to using "none" as media instead. note that the error was basically cosmetic as the vm would start just fine. forum thread: https://forum.proxmox.com/threads/use-of-uninitialized-value-path-in-pattern-match-m-at-usr-share-perl5-pve-qemuserver-pm-line-1622.119592/ Signed-off-by: Stefan Sterz --- PVE/QemuServer.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index dd6ea3e..bc935df 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -1292,6 +1292,9 @@ sub get_cdrom_path { return $cdrom_path = "/dev/cdrom" if -l "/dev/cdrom"; return $cdrom_path = "/dev/cdrom1" if -l "/dev/cdrom1"; return $cdrom_path = "/dev/cdrom2" if -l "/dev/cdrom2"; + + warn "there is no physical cdrom drive that can be used. defaulting back to 'none'."; + return ''; } sub get_iso_path { -- 2.30.2