From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.tschlatscher@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5A1C8F686 for <pve-devel@lists.proxmox.com>; Fri, 16 Dec 2022 14:39:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 42632226B4 for <pve-devel@lists.proxmox.com>; Fri, 16 Dec 2022 14:39:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Fri, 16 Dec 2022 14:39:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6BDCA438EA for <pve-devel@lists.proxmox.com>; Fri, 16 Dec 2022 14:39:05 +0100 (CET) From: Daniel Tschlatscher <d.tschlatscher@proxmox.com> To: pve-devel@lists.proxmox.com Date: Fri, 16 Dec 2022 14:36:50 +0100 Message-Id: <20221216133655.510957-1-d.tschlatscher@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.118 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [helpers.pm, jsonschema.pm, qemuserver.pm, qemu.pm] Subject: [pve-devel] [PATCH common/qemu-server/manager v3] fix #3502: VM start timeout config parameter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 16 Dec 2022 13:39:06 -0000 This patch series adds a an option to specify a timeout value in the config for starting VMs. The minimum is 0 seconds, which disables the timeout completely. The maximum is 86400 seconds, equivalent to 1 day. The timeout value can also be passed via the CLI, which always overrides the setting. If no value for timeout is passed, the timeout will either be read from the config, or if unavailable, chosen heuristically like before, with a default of 30 seconds in most cases. For this, a new property string called "startoptions" is added. Currently only the VM start timeout is configurable with it. Changes from v2 * Rebased to current repository masters * Some minor code cleanups * Reordered the commits and added a cover letter pve-common: Daniel Tschlatscher (1): VM start timeout config parameter src/PVE/JSONSchema.pm | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) qemu-server: Daniel Tschlatscher (3): fix #3502: VM start timeout config parameter await and kill lingering KVM thread when VM start reaches timeout make the timeout value editable when the VM is locked PVE/API2/Qemu.pm | 27 ++++++++++++++++++++++++++ PVE/QemuServer.pm | 41 ++++++++++++++++++++++++++++++++------- PVE/QemuServer/Helpers.pm | 4 ++++ 3 files changed, 65 insertions(+), 7 deletions(-) pve-manager: Daniel Tschlatscher (1): VM start Timeout "Options" parameter in the GUI www/manager6/qemu/Options.js | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) -- 2.30.2