From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3D22DF1C5 for ; Wed, 14 Dec 2022 14:43:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 09D262B47B for ; Wed, 14 Dec 2022 14:42:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 14 Dec 2022 14:42:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3A4FA43BD2 for ; Wed, 14 Dec 2022 14:42:43 +0100 (CET) Date: Wed, 14 Dec 2022 14:42:42 +0100 From: Wolfgang Bumiller To: Stefan Hrdlicka Cc: pve-devel@lists.proxmox.com Message-ID: <20221214134242.wckxecefpv375bfx@casey.proxmox.com> References: <20221213151419.3658005-1-s.hrdlicka@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221213151419.3658005-1-s.hrdlicka@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.220 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [ipset.pm, firewall.pm] Subject: [pve-devel] applied-series: [PATCH V3 firewall 0/2] allow non zero ip address host bits to be entered X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2022 13:43:14 -0000 applied both patches, thanks On Tue, Dec 13, 2022 at 04:14:17PM +0100, Stefan Hrdlicka wrote: > V2 -> V3 > * review fix: removed closure from clean_cidr > > V1 -> V2 > * zero out host bits instead of ignoring error > * regex "cleanup" > > Stefan Hrdlicka (2): > allow non zero ip address host bits to be entered > cleanup: don't capture "/xx" of CIDR > > src/PVE/API2/Firewall/IPSet.pm | 2 +- > src/PVE/Firewall.pm | 21 +++++++++++++++++++-- > 2 files changed, 20 insertions(+), 3 deletions(-) > > -- > 2.30.2