From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 35F4FDF20 for ; Tue, 6 Dec 2022 12:07:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 171DF2E093 for ; Tue, 6 Dec 2022 12:06:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 6 Dec 2022 12:06:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 52CFA44DDD for ; Tue, 6 Dec 2022 12:06:36 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 6 Dec 2022 12:06:33 +0100 Message-Id: <20221206110635.1885744-5-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221206110635.1885744-1-d.csapak@proxmox.com> References: <20221206110635.1885744-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v2 1/3] ui: realm: sync: don't use realm defaults for remove-vanished X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2022 11:07:07 -0000 if we don't manually set it to the empty string, it will use the realm default, which might be unexpected. this way, the sync always does what the user saw in the sync window. Signed-off-by: Dominik Csapak --- www/manager6/dc/SyncWindow.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/dc/SyncWindow.js b/www/manager6/dc/SyncWindow.js index c46dd7017..0ac109196 100644 --- a/www/manager6/dc/SyncWindow.js +++ b/www/manager6/dc/SyncWindow.js @@ -42,6 +42,8 @@ Ext.define('PVE.dc.SyncWindow', { }); if (vanished_opts.length > 0) { params['remove-vanished'] = vanished_opts.join(';'); + } else { + params['remove-vanished'] = 'none'; } params['dry-run'] = is_preview ? 1 : 0; -- 2.30.2