From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 2AFA7C436
for <pve-devel@lists.proxmox.com>; Mon, 28 Nov 2022 16:55:45 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 0F78735F3E
for <pve-devel@lists.proxmox.com>; Mon, 28 Nov 2022 16:55:15 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Mon, 28 Nov 2022 16:55:13 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0F82044E3B
for <pve-devel@lists.proxmox.com>; Mon, 28 Nov 2022 16:55:13 +0100 (CET)
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Mon, 28 Nov 2022 16:55:09 +0100
Message-Id: <20221128155509.142996-1-f.ebner@proxmox.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.028 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH storage] plugin: file size info: use fallback
for actual size
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 28 Nov 2022 15:55:45 -0000
The actual-size property is an optional property in the QAPI
definition for ImageInfo. If it's not set, simply use the information
from stat() as a fallback. This is essentially the same
raw_get_allocated_file_size() in QEMU does anyways.
Reported in the community forum:
https://forum.proxmox.com/threads/118443/post-513421
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Thanks to Mira for setting up a GlusterFS instance and discussing the
issue with me!
I'm not sure why QEMU fails here, didn't see much that could go wrong
beside the fstat() call failing. But our stat() call in the beginning
of file_size_info already succeeded at that point :/ The mysteries of
QEMU+GlusterFS.
Also, it's a bit strange to call qemu-img info regardless of whether
the image is a VM image or not. E.g., this results in the format
property for backups to always be raw, rather than the backup format.
Should we change that (for 8.0)?
PVE/Storage/Plugin.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
index 8a41df1..7773ac3 100644
--- a/PVE/Storage/Plugin.pm
+++ b/PVE/Storage/Plugin.pm
@@ -899,6 +899,7 @@ sub file_size_info {
}
my ($size, $format, $used, $parent) = $info->@{qw(virtual-size format actual-size backing-filename)};
+ $used ||= $st->blocks * 512;
($size) = ($size =~ /^(\d+)$/) or die "size '$size' not an integer\n"; # untaint
# coerce back from string
--
2.30.2