From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4E92ABBF2 for ; Fri, 25 Nov 2022 15:40:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2CEC31DC7B for ; Fri, 25 Nov 2022 15:40:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 25 Nov 2022 15:40:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0500A44E3B for ; Fri, 25 Nov 2022 15:40:37 +0100 (CET) From: Stefan Hrdlicka To: pve-devel@lists.proxmox.com Date: Fri, 25 Nov 2022 15:40:04 +0100 Message-Id: <20221125144008.2988072-4-s.hrdlicka@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221125144008.2988072-1-s.hrdlicka@proxmox.com> References: <20221125144008.2988072-1-s.hrdlicka@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH V4 pve-container 3/7] add linked clone check for LXC container template deletion X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Nov 2022 14:40:39 -0000 prevent partial storage deletion if the template has a linked clone container Signed-off-by: Stefan Hrdlicka --- src/PVE/LXC.pm | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index fe68f75..7164462 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -865,6 +865,18 @@ sub destroy_lxc_container { $purge_unreferenced, $ignore_storage_errors) = @_; my $volids = {}; + + if ($conf->{template}) { + PVE::LXC::Config->foreach_volume_full($conf, {incldue_unused => 1}, sub { + my ($ms, $mountpoint) = @_; + my $volid = $mountpoint->{volume}; + return if !$volid || $volid =~ m|^/|; + my $result; + eval{ $result = PVE::Storage::volume_is_base_and_used($storage_cfg, $volid) }; + die "base volume '$volid' is still in use by linked cloned\n" if $result; + }); + } + my $remove_volume = sub { my ($ms, $mountpoint) = @_; -- 2.30.2