From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5E168BBF3 for ; Fri, 25 Nov 2022 15:40:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4042A1DC7E for ; Fri, 25 Nov 2022 15:40:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 25 Nov 2022 15:40:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0905844E4C for ; Fri, 25 Nov 2022 15:40:37 +0100 (CET) From: Stefan Hrdlicka To: pve-devel@lists.proxmox.com Date: Fri, 25 Nov 2022 15:40:03 +0100 Message-Id: <20221125144008.2988072-3-s.hrdlicka@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221125144008.2988072-1-s.hrdlicka@proxmox.com> References: <20221125144008.2988072-1-s.hrdlicka@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH V4 pve-container 2/7] adapt behavior for detaching/removing a mount point X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Nov 2022 14:40:39 -0000 detach of a mount point with a removed underlying storage causes it to be labeled as a an 'unused disk' remove of a 'unused disk' with a removed underlying storage causes it to be removed from the configuration Signed-off-by: Stefan Hrdlicka --- src/PVE/LXC/Config.pm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index b1f779b..e8fbd86 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -1421,13 +1421,17 @@ sub vmconfig_apply_pending { foreach my $opt (sort keys %$pending_delete_hash) { next if $selection && !$selection->{$opt}; eval { + my ($storeid, $volname) = PVE::Storage::parse_volume_id($conf->{$opt}); if ($opt =~ m/^mp(\d+)$/) { my $mp = $class->parse_volume($opt, $conf->{$opt}); if ($mp->{type} eq 'volume') { $class->add_unused_volume($conf, $mp->{volume}) if !$class->is_volume_in_use($conf, $conf->{$opt}, 1, 1); } - } elsif ($opt =~ m/^unused(\d+)$/) { + } elsif ( + $opt =~ m/^unused(\d+)$/ + && PVE::Storage::storage_config($storecfg, $storeid, 1) + ) { PVE::LXC::delete_mountpoint_volume($storecfg, $vmid, $conf->{$opt}) if !$class->is_volume_in_use($conf, $conf->{$opt}, 1, 1); } -- 2.30.2