From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 782FDBBF6 for ; Fri, 25 Nov 2022 15:40:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5FA661DC84 for ; Fri, 25 Nov 2022 15:40:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 25 Nov 2022 15:40:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 06A9344E47 for ; Fri, 25 Nov 2022 15:40:37 +0100 (CET) From: Stefan Hrdlicka To: pve-devel@lists.proxmox.com Date: Fri, 25 Nov 2022 15:40:01 +0100 Message-Id: <20221125144008.2988072-1-s.hrdlicka@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH SERIES V4 pve-container/qemu-server/pve-manager 0/7] fix #3711 & adapt drive detach/remove behavior X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Nov 2022 14:40:39 -0000 V3 -> V4: # pve-container * add check for linked clones to avoid partially deleting volumes # pve-container * remove ignore_storage_errors * ignores now errors with PVE::Storage::path # pve-manager * remove checkbox ignore errors checkbox from VM delete V2 -> V3: # pve-storage * change removed # pve-container * remove storage_exists * reduce code lines used # qemu-server * reduce code lines used # pve-manager * no change V1 -> V2: # overall * matched detaching/removing drives behavior for VM & containers It currently works this way: - Detach drive - drive shows up as unused - remove drive - drive will be removed without removing data (obviously) # pve-storage * added storage_exists function for matching detach/remove behavoir # pve-container * review fixes: * variable naming * desciption string adapted * moved eval further up the call chain * removed ticket number form cleanup * check if storage exists for unused disks # qemu-server * add same force option as for containers * match detach/remove behavoir between VM/container * shorten line # pve-manager * added same option for VMs as for containers Stefan Hrdlicka (4): fix #3711: optionally allow CT deletion to complete on disk volume removal errors adapt behavior for detaching/removing a mount point add linked clone check for LXC container template deletion cleanup: remove spaces from empty lines src/PVE/API2/LXC.pm | 8 ++++++++ src/PVE/LXC.pm | 28 +++++++++++++++++++++------- src/PVE/LXC/Config.pm | 6 +++++- 3 files changed, 34 insertions(+), 8 deletions(-) -- 2.30.2