From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BE8E3B311; Wed, 23 Nov 2022 15:53:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5EFF323AAF; Wed, 23 Nov 2022 15:53:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Wed, 23 Nov 2022 15:53:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9E0A944DCA; Wed, 23 Nov 2022 15:53:02 +0100 (CET) From: Daniel Tschlatscher To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com Date: Wed, 23 Nov 2022 15:52:06 +0100 Message-Id: <20221123145210.592981-1-d.tschlatscher@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.137 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH backup/pmg-api/manager/common v4] fix: #3971 Tasklog download button X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2022 14:53:38 -0000 This patch series' aim is to add a download button in the tasklog- viewer GUI so that users may access the tasklog more easily. (The tasklog-viewer only displays 50 lines at a time) Instead of suddenly returning a file stream when the 'limit' parameter is set to 0, now, a new parameter 'download' needs to be passed. This parameter is mutually exclusive with the other parameters. Before, the backup server backend would simply return an array with no content for a call with parameter 'limit=0', the pmg and pve backends would fall back to the default of 50. To unify this, setting 'limit=0' will now return everything until the end of the log file in the normal json format. This is useful in case it is unknown how many lines the log contains, with 0 being a bit nonsensical for other cases anyway. If no parameter is given, the default of 50 still applies. => Thanks to Fabian for the review! changes from v3 * parameter 'download' for downloading the task log * limit=0 now returns the whole log instead * miscellaneous code clean up proxmox-backup: Daniel Tschlatscher (1): make tasklog downloadable in the backup server backend src/api2/node/tasks.rs | 209 +++++++++++++++++++++++++---------------- 1 file changed, 129 insertions(+), 80 deletions(-) pmg-api: Daniel Tschlatscher (1): make tasklog downloadable in the PMG backend src/PMG/API2/Tasks.pm | 60 ++++++++++++++++++++++++++----------------- 1 file changed, 36 insertions(+), 24 deletions(-) pve-manager: Daniel Tschlatscher (1): make task log downloadable in the PVE manager backend PVE/API2/Tasks.pm | 48 ++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 41 insertions(+), 7 deletions(-) pve-common: Daniel Tschlatscher (1): return whole log file if limit is 0 src/PVE/Tools.pm | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) -- 2.30.2