From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C1C3BA9C6 for ; Mon, 21 Nov 2022 10:54:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9FD7D2A8CE for ; Mon, 21 Nov 2022 10:54:18 +0100 (CET) Received: from bastionodiso.odiso.net (bastionodiso.odiso.net [IPv6:2a0a:1580:2000::2d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 21 Nov 2022 10:54:18 +0100 (CET) Received: from kvmformation3.odiso.net (formationkvm3.odiso.net [10.3.94.12]) by bastionodiso.odiso.net (Postfix) with ESMTP id 60FA680BA; Mon, 21 Nov 2022 10:54:05 +0100 (CET) Received: by kvmformation3.odiso.net (Postfix, from userid 0) id 4EAFCFFBCD; Mon, 21 Nov 2022 10:54:05 +0100 (CET) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Mon, 21 Nov 2022 10:54:04 +0100 Message-Id: <20221121095404.1628780-1-aderumier@odiso.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% HEADER_FROM_DIFFERENT_DOMAINS 0.25 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-network] network: add|del_fdb: fix learning check X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2022 09:54:18 -0000 ovs port don't have sysfs path "/sys/class/net/$iface/brport/learning" We need to check if the value is undef too Signed-off-by: Alexandre Derumier --- src/PVE/Network.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm index 26d8cb1..d1d2e5e 100644 --- a/src/PVE/Network.pm +++ b/src/PVE/Network.pm @@ -300,7 +300,7 @@ sub add_bridge_fdb { my ($iface, $mac) = @_; my $learning = PVE::Tools::file_read_firstline("/sys/class/net/$iface/brport/learning"); - return if $learning; + return if !defined($learning) || $learning == 1; my ($vmid, $devid) = &$parse_tap_device_name($iface, 1); return if !defined($vmid); @@ -320,7 +320,7 @@ sub del_bridge_fdb { my ($iface, $mac) = @_; my $learning = PVE::Tools::file_read_firstline("/sys/class/net/$iface/brport/learning"); - return if $learning; + return if !defined($learning) || $learning == 1; my ($vmid, $devid) = &$parse_tap_device_name($iface, 1); return if !defined($vmid); -- 2.30.2