From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DDE4AA8B5 for ; Mon, 21 Nov 2022 08:54:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BEA8029371 for ; Mon, 21 Nov 2022 08:53:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 21 Nov 2022 08:53:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DDF9244DAE for ; Mon, 21 Nov 2022 08:53:42 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 21 Nov 2022 08:53:42 +0100 Message-Id: <20221121075342.291834-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221121075342.291834-1-d.csapak@proxmox.com> References: <20221121075342.291834-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit 2/2] log/journal view: fix acces to me after destroying X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2022 07:54:14 -0000 it can happen that the view is destroyed during an api call, so we should check if it's destroyed as the first thing in the callback if the view is destroyed, there is nothing we can do here, so simply return Signed-off-by: Dominik Csapak --- src/panel/JournalView.js | 3 +++ src/panel/LogView.js | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/panel/JournalView.js b/src/panel/JournalView.js index f3af36b..32c005a 100644 --- a/src/panel/JournalView.js +++ b/src/panel/JournalView.js @@ -143,6 +143,9 @@ Ext.define('Proxmox.panel.JournalView', { waitMsgTarget: !livemode ? view : undefined, method: 'GET', success: function(response) { + if (me.isDestroyed) { + return; + } Proxmox.Utils.setErrorMask(me, false); let lines = response.result.data; me.updateView(lines, livemode, top); diff --git a/src/panel/LogView.js b/src/panel/LogView.js index dcbd002..44aa8e3 100644 --- a/src/panel/LogView.js +++ b/src/panel/LogView.js @@ -98,6 +98,9 @@ Ext.define('Proxmox.panel.LogView', { params: viewModel.get('params'), method: 'GET', success: function(response) { + if (me.isDestroyed) { + return; + } Proxmox.Utils.setErrorMask(me, false); let total = response.result.total; let lines = []; -- 2.30.2