From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5DE0C9AFC for ; Fri, 18 Nov 2022 12:59:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3F86E1814 for ; Fri, 18 Nov 2022 12:59:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 18 Nov 2022 12:59:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C60FB44D6C for ; Fri, 18 Nov 2022 12:59:19 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 18 Nov 2022 12:59:17 +0100 Message-Id: <20221118115919.2477011-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221118115919.2477011-1-d.csapak@proxmox.com> References: <20221118115919.2477011-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL 0.065 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict =?UTF-8?Q?Alignment=0A=09?=SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 3/4] ui: tags: implement dirty tracking for inline editing X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2022 11:59:51 -0000 similar to how regular forms are tracked Signed-off-by: Dominik Csapak --- www/manager6/form/TagEdit.js | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/www/manager6/form/TagEdit.js b/www/manager6/form/TagEdit.js index 18d8927d7..fc2eba99b 100644 --- a/www/manager6/form/TagEdit.js +++ b/www/manager6/form/TagEdit.js @@ -30,12 +30,12 @@ Ext.define('PVE.panel.TagEditContainer', { newtags.forEach((tag) => { me.addTag(tag); }); - me.updateFilter(); view.suspendLayout = false; view.updateLayout(); if (!force) { me.oldTags = tagstring; } + me.tagsChanged(); }, onRender: function(v) { @@ -116,6 +116,7 @@ Ext.define('PVE.panel.TagEditContainer', { let targetCmp = Ext.getCmp(target.id); view.remove(sourceCmp, { destroy: false }); view.insert(view.items.indexOf(targetCmp), sourceCmp); + me.tagsChanged(); }, }); }, @@ -172,7 +173,7 @@ Ext.define('PVE.panel.TagEditContainer', { me.getView().updateLayout(); }, - updateFilter: function() { + tagsChanged: function() { let me = this; let tags = []; me.forEachTag(cmp => { @@ -180,6 +181,7 @@ Ext.define('PVE.panel.TagEditContainer', { tags.push(cmp.tag); } }); + me.getViewModel().set('isDirty', me.oldTags !== tags.join(',')); me.forEachTag(cmp => { cmp.updateFilter(tags); }); @@ -208,11 +210,10 @@ Ext.define('PVE.panel.TagEditContainer', { tag, mode: vm.get('editMode') ? 'editable' : 'normal', listeners: { - change: (field, newTag) => { - me.updateFilter(); - }, + change: 'tagsChanged', destroy: function() { vm.set('tagCount', vm.get('tagCount') - 1); + me.tagsChanged(); }, keypress: function(key) { if (key === 'Enter') { @@ -225,7 +226,7 @@ Ext.define('PVE.panel.TagEditContainer', { }); if (isNew) { - me.updateFilter(); + me.tagsChanged(); tagField.selectText(); } @@ -265,6 +266,7 @@ Ext.define('PVE.panel.TagEditContainer', { tagCount: 0, editMode: false, canEdit: true, + isDirty: false, }, formulas: { @@ -331,6 +333,7 @@ Ext.define('PVE.panel.TagEditContainer', { tooltip: gettext('Finish Edit'), bind: { hidden: '{!editMode}', + disabled: '{!isDirty}', }, hidden: true, ui: 'default-toolbar', -- 2.30.2