From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 15B248E5C for ; Wed, 16 Nov 2022 18:35:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EFC26235F0 for ; Wed, 16 Nov 2022 18:34:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 16 Nov 2022 18:34:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 32F5E44035 for ; Wed, 16 Nov 2022 18:34:52 +0100 (CET) From: Leo Nunner To: pve-devel@lists.proxmox.com Date: Wed, 16 Nov 2022 18:34:27 +0100 Message-Id: <20221116173430.257506-1-l.nunner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL -0.099 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict =?UTF-8?Q?Alignment=0A=09?=SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF =?UTF-8?Q?record=0A=09?=URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [drive.pm, qemu.pm] Subject: [pve-devel] [PATCH v2 qemu-server manager docs] Properly check cloud-init drive permissions X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2022 17:35:23 -0000 The "Add CloudInit Drive" button in the UI was only enabled when the user had Sys.Console permissions, even if the other correct permissions were set. The backend check for these permissions also needed to be revamped to be more consistent. Changes from v1: - Switch to purely checking for VM.Config.CDROM (discussed offlist) - Document VM.Config.Cloudinit in docs - Whitespaces fixes manager: Leo Nunner (1): fix #4321: properly check cloud-init drive permissions www/manager6/qemu/HardwareView.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) qemu-server: Leo Nunner (1): fix #4321: properly check cloud-init drive permissions PVE/API2/Qemu.pm | 6 ++++-- PVE/QemuServer/Drive.pm | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) docs: Leo Nunner (1): Document VM.Config.Cloudinit permission pveum.adoc | 1 + 1 file changed, 1 insertion(+) -- 2.30.2