From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4B5318E24 for ; Wed, 16 Nov 2022 18:14:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1744A23292 for ; Wed, 16 Nov 2022 18:14:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 16 Nov 2022 18:14:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 90F6944CF9; Wed, 16 Nov 2022 18:14:09 +0100 (CET) From: Wolfgang Bumiller To: pve-devel@lists.proxmox.com Date: Wed, 16 Nov 2022 18:14:02 +0100 Message-Id: <20221116171408.216775-1-w.bumiller@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL 0.233 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict =?UTF-8?Q?Alignment=0A=09?=SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF =?UTF-8?Q?record=0A=09?=URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, qemu.pm, cloudinit.pm] Subject: [pve-devel] [PATCH qemu-server 0/6] Manage [special:cloudinit] in hotplug code X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2022 17:14:41 -0000 The inital series by Alexandre always dumped this section into the config even if no cloud-init was being used and the api to get the pending changes performed filtering which should instead be part of the hotplug code. See the individual commit messages. This partially reverts some of Thomas' cleanups as - unless I missed something - image generation and writing of the config only happens in paths that are already allowed to write it, plus, the hotplug code will now fully manage the [special:cloudinit] section, including removing values which have been reverted to the state that was used for the last cloud-init image generation. Wolfgang Bumiller (6): Revert "cloudinit: avoid unsafe write of VM config" Partially-revert "cloudinit: add cloudinit section for current generated config" delay cloudinit generation in hotplug record cloud-init changes in the cloudinit section don't call 'cleanup_config' the cloudinit section drop get_pending_changes and simplify cloudinit_pending api call PVE/API2/Qemu.pm | 44 ++++++------ PVE/QemuServer.pm | 132 +++++++++++++++++++++++++++++------- PVE/QemuServer/Cloudinit.pm | 122 ++++++--------------------------- 3 files changed, 153 insertions(+), 145 deletions(-) -- 2.30.2