From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7A3A185B9 for ; Tue, 15 Nov 2022 14:23:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 561413997 for ; Tue, 15 Nov 2022 14:23:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 15 Nov 2022 14:23:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AB97A43D35 for ; Tue, 15 Nov 2022 14:23:12 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 15 Nov 2022 14:23:12 +0100 Message-Id: <20221115132312.1270059-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL 0.065 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict =?UTF-8?Q?Alignment=0A=09?=SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: BackupEdit: fix reset tracking X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2022 13:23:47 -0000 when the mode changes, we set the pool selector visible/hidden, but we never disabled/enabled it. this tripped up the dirty state of the form always showing the reset button as enabled. to fix it, properly enable/disable it Signed-off-by: Dominik Csapak --- www/manager6/dc/Backup.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index c81a76cea..4638cbb68 100644 --- a/www/manager6/dc/Backup.js +++ b/www/manager6/dc/Backup.js @@ -322,10 +322,12 @@ Ext.define('PVE.dc.BackupEdit', { vmgrid.setDisabled(true); vmidField.setValue(''); selPool.setVisible(true); + selPool.setDisabled(false); selPool.allowBlank = false; selectPoolMembers(selPool.value); } else { selPool.setVisible(false); + selPool.setDisabled(true); selPool.allowBlank = true; } let list = vmidField.getValue(); -- 2.30.2