From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BE9B384BD for ; Tue, 15 Nov 2022 14:03:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BE9542EBF for ; Tue, 15 Nov 2022 14:02:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 15 Nov 2022 14:02:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E1E8644C9D for ; Tue, 15 Nov 2022 14:02:50 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 15 Nov 2022 14:02:37 +0100 Message-Id: <20221115130248.1007325-13-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221115130248.1007325-1-d.csapak@proxmox.com> References: <20221115130248.1007325-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL 0.065 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict =?UTF-8?Q?Alignment=0A=09?=SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF =?UTF-8?Q?record=0A=09?=URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [api2.pm] Subject: [pve-devel] [PATCH manager v10 02/13] api: add /ui-options api call X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2022 13:03:30 -0000 which contains ui relevant options, like the console preference and tag-style also contains the list of allowed tags Signed-off-by: Dominik Csapak --- PVE/API2.pm | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+) diff --git a/PVE/API2.pm b/PVE/API2.pm index a42561604..7c1d0830d 100644 --- a/PVE/API2.pm +++ b/PVE/API2.pm @@ -118,6 +118,7 @@ __PACKAGE__->register_method ({ my $res = {}; + # TODO remove with next major release my $datacenter_confg = eval { PVE::Cluster::cfs_read_file('datacenter.cfg') } // {}; for my $k (qw(console)) { $res->{$k} = $datacenter_confg->{$k} if exists $datacenter_confg->{$k}; @@ -130,4 +131,64 @@ __PACKAGE__->register_method ({ return $res; }}); +__PACKAGE__->register_method ({ + name => 'ui-options', + path => 'ui-options', + method => 'GET', + permissions => { user => 'all' }, + description => "Global options regarding the UI.", + parameters => { + additionalProperties => 0, + properties => {}, + }, + returns => { + type => "object", + properties => { + console => { + type => 'string', + enum => ['applet', 'vv', 'html5', 'xtermjs'], + optional => 1, + description => 'The default console viewer to use.', + }, + 'tag-style' => { + type => 'string', + optional => 1, + description => 'Cluster wide tag style overrides', + }, + 'allowed-tags' => { + type => 'array', + optional => 1, + description => 'A list of allowed tags that exist.', + items => { + type => 'string', + description => 'A tag the user is allowed to set.', + }, + }, + }, + }, + code => sub { + my ($param) = @_; + + my $res = {}; + + my $rpcenv = PVE::RPCEnvironment::get(); + my $authuser = $rpcenv->get_user(); + + my $datacenter_confg = eval { PVE::Cluster::cfs_read_file('datacenter.cfg') } // {}; + for my $k (qw(console tag-style)) { + $res->{$k} = $datacenter_confg->{$k} if exists $datacenter_confg->{$k}; + } + + my $privileged_user = $rpcenv->check($authuser, '/', ['Sys.Modify'], 1); + + my $tags = PVE::DataCenterConfig::get_allowed_tags($privileged_user, sub { + my ($vmid) = @_; + return $rpcenv->check_vm_perm($authuser, $vmid, undef, ['VM.Audit'], 0, 1); + }); + + $res->{'allowed-tags'} = [sort keys $tags->%*]; + + return $res; + }}); + 1; -- 2.30.2