From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 718D5917D7 for ; Mon, 14 Nov 2022 12:39:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4788A229B2 for ; Mon, 14 Nov 2022 12:38:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 14 Nov 2022 12:38:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 303F443CBF for ; Mon, 14 Nov 2022 12:38:42 +0100 (CET) From: Stefan Sterz To: pve-devel@lists.proxmox.com Date: Mon, 14 Nov 2022 12:38:26 +0100 Message-Id: <20221114113828.286081-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL -0.102 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict =?UTF-8?Q?Alignment=0A=09?=SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v3 0/2] pve fix help buttons by accounting for keys in widget toolkit X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2022 11:39:14 -0000 this patch series fixes an issue where `onlineHelp` keys, that were only used by components in the widget toolkit, were not properly mapped to the corresponding anchors in the docs. this lead to affected help buttons only showing an error message. this series first fixes `pve-docs` by making `asciidoc-pve` a bit less aggressiv in order to avoid keys that are set by cbind. then it adds the toolkit as a build dependency to `pve-manager` and scans the toolkit for keys there when building the front-end. changes from v2, thanks @ Thomas Lamprecht: * rebase to current master * move to greedy regex changes from v1, thanks @ Thomas Lamprecht: * scan the widget toolkit too and not just components in `pve-manager` Stefan Sterz (1): asciidoc-pve: disallow certain characters in onlineHelp keys asciidoc-pve.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Stefan Sterz (1): fix #4328: ui: add widget toolkit to dependencies of OnlineHelpInfo.js debian/control | 1 + www/manager6/Makefile | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) -- 2.30.2