From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E50E28DE02; Thu, 10 Nov 2022 11:37:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B22BB2503B; Thu, 10 Nov 2022 11:36:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Thu, 10 Nov 2022 11:36:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F04654379F; Thu, 10 Nov 2022 11:36:34 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com Date: Thu, 10 Nov 2022 11:36:28 +0100 Message-Id: <20221110103634.2177856-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox-backup/common/storage v4] improve file-restore timeout behaviour X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Nov 2022 10:37:08 -0000 this series improves the behaviour of the file-restore when some mount operations take longer than the 30 second pveproxy timeout and enables/disables the automatic increasing of memory depending on the users privileges depends (i'll add it to the seperate patches too) pve-storage 1/3 fixes the currently broken error output and does not depend on the rest of the series pve-storage 2/3 depends on pve-common 1/2 pve-storage 3/3 depends on pve-common 2/2 pve-common 2/2 depends on proxmox-backup changes from v3: * don't hardcode the timeout parameter in pve-common, but make it a hash were we explicitely extract the timeout * split the pve-storage commit into two, one for handling the error format and one for the timeout * add patches to handle the dynamic memory behaviour changes from v2: * couple the error format to 'ouput-format' instead of 'json-error' * remove 'error' property from 'error json object' (was redundant) * always expect an error when we get an object and always treat it as ok when we get a list changes from v1: * rebased on master * moved the json-error and timeout directly into pve-common (hardcoded) since there is only one usage of that function proxmox-backup: Dominik Csapak (1): file-restore: make dynamic memory behaviour controllable proxmox-file-restore/src/block_driver.rs | 10 +++- proxmox-file-restore/src/block_driver_qemu.rs | 6 ++- proxmox-file-restore/src/main.rs | 54 +++++++++++++++++-- 3 files changed, 61 insertions(+), 9 deletions(-) pve-common: Dominik Csapak (2): PBSClient: file_restore_list: add extraParams and use timeout PBSClient: add optional 'dynamic-memory' parameter to file-restore commands src/PVE/PBSClient.pm | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) pve-storage: Dominik Csapak (3): api: FileRestore: decode and return proper error of file-restore listing api: FileRestore: make use of file-restores and guis timeout mechanism api: FileRestore: allow automatic memory increase for privileged users PVE/API2/Storage/FileRestore.pm | 48 +++++++++++++++++++++++++++------ 1 file changed, 40 insertions(+), 8 deletions(-) -- 2.30.2