From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2E0328DC1A for ; Wed, 9 Nov 2022 16:39:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F296A1E4F4 for ; Wed, 9 Nov 2022 16:38:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 9 Nov 2022 16:38:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3715B43313 for ; Wed, 9 Nov 2022 16:38:36 +0100 (CET) From: Daniel Tschlatscher To: pve-devel@lists.proxmox.com Date: Wed, 9 Nov 2022 16:37:09 +0100 Message-Id: <20221109153709.677876-1-d.tschlatscher@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.156 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v7] ui: vm network: allow to override MTU for virtio devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2022 15:39:08 -0000 From: Oguz Bektas we already have the 'mtu' option in the API, so we can just expose that option inside the 'Advanced' menu for virtio network interfaces. Signed-off-by: Oguz Bektas Moved the message tooltip below the advanced columns to avoid the line break and make it more visually pleasing. Signed-off-by: Daniel Tschlatscher --- Changes from v6 * The message tooltip is now in the advancedColumnB www/manager6/qemu/NetworkEdit.js | 36 ++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js index b39cffdc..86067707 100644 --- a/www/manager6/qemu/NetworkEdit.js +++ b/www/manager6/qemu/NetworkEdit.js @@ -19,6 +19,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', { me.network.macaddr = values.macaddr; me.network.disconnect = values.disconnect; me.network.queues = values.queues; + me.network.mtu = values.mtu; if (values.rate) { me.network.rate = values.rate; @@ -33,6 +34,17 @@ Ext.define('PVE.qemu.NetworkInputPanel', { return params; }, + viewModel: { + data: { + networkModel: '', + mtu: '', + }, + formulas: { + isVirtio: get => get('networkModel') === 'virtio', + showMtuHint: get => get('mtu') === 1, + }, + }, + setNetwork: function(confid, data) { var me = this; @@ -93,6 +105,18 @@ Ext.define('PVE.qemu.NetworkInputPanel', { fieldLabel: gettext('Disconnect'), name: 'disconnect', }, + { + xtype: 'proxmoxintegerfield', + name: 'mtu', + fieldLabel: 'MTU', + bind: { + disabled: '{!isVirtio}', + value: '{mtu}', + }, + minValue: 1, + maxValue: 65520, + allowBlank: true, + }, ]; if (me.insideWizard) { @@ -112,6 +136,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', { 'macaddr', 'rate', 'queues', + 'mtu', ]; fields.forEach(function(fieldname) { me.down('field[name='+fieldname+']').setDisabled(value); @@ -130,6 +155,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', { xtype: 'pveNetworkCardSelector', name: 'model', fieldLabel: gettext('Model'), + bind: '{networkModel}', value: PVE.qemu.OSDefaults.generic.networkCard, allowBlank: false, }, @@ -162,6 +188,16 @@ Ext.define('PVE.qemu.NetworkInputPanel', { allowBlank: true, }, ]; + me.advancedColumnB = [ + { + xtype: 'displayfield', + userCls: 'pmx-hint', + value: gettext("Use the special value '1' to inherit the MTU value from the underlying bridge"), + bind: { + hidden: '{!showMtuHint}', + }, + }, + ]; me.callParent(); }, -- 2.30.2