From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 721DF8CA7D for ; Fri, 4 Nov 2022 10:19:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 526013B0 for ; Fri, 4 Nov 2022 10:19:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 4 Nov 2022 10:19:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6163B44B48 for ; Fri, 4 Nov 2022 10:19:11 +0100 (CET) From: Daniel Tschlatscher To: pve-devel@lists.proxmox.com Date: Fri, 4 Nov 2022 10:18:47 +0100 Message-Id: <20221104091847.60112-1-d.tschlatscher@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.161 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] [PATCH manager] gui: fix firewall security group help button chapter link X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2022 09:19:13 -0000 The help button under Datacenter > Firewall > Security Group did not have the proper help chapter link set. First reported here: https://forum.proxmox.com/threads/broken-help-link-in-proxmox-gui.117503/ Signed-off-by: Daniel Tschlatscher --- I noticed that the onlineHelp field for our custom classes is sometimes defined outside of the class, in the Config which defines the layout of the navigation panel, and sometimes inside of the class directly. This time I added it inside the class, as it seems to be the more commonly used thing. Though, is there any preference for this? www/manager6/dc/SecurityGroups.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/dc/SecurityGroups.js b/www/manager6/dc/SecurityGroups.js index 5fb6860d..26172bf3 100644 --- a/www/manager6/dc/SecurityGroups.js +++ b/www/manager6/dc/SecurityGroups.js @@ -199,6 +199,7 @@ Ext.define('PVE.SecurityGroups', { alias: 'widget.pveSecurityGroups', title: 'Security Groups', + onlineHelp: 'pve_firewall_security_groups', layout: 'border', -- 2.30.2